Add GitHub Actions CI with a PHP version matrix - #9
Merged
Conversation
Adds a setup-php matrix over 7.4, 8.0, 8.1 and 8.2 with fail-fast disabled, mirroring packaged/dal and matching the versions the CircleCI config already built. Drops satooshi/php-coveralls from require-dev. It is abandoned: v1.0.2 caps out at PHP 7.x, and the earlier releases pull symfony/yaml 2.x/3.x, which Composer now refuses to install because of published security advisories. With it present "composer install" cannot resolve on any supported PHP version, so CI could not run at all. Nothing referenced it -- the CircleCI config never invoked coveralls. The existing CircleCI config is left in place. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
TomK
added a commit
that referenced
this pull request
Sep 4, 2026
Follows on from #9, which added the workflow with 7.4 through 8.2. Adds the three current releases, so the matrix now runs 7.4, 8.0, 8.1, 8.2, 8.3, 8.4 and 8.5. Verified against a clean checkout: fresh composer install plus the full suite on PHP 8.5.10 exits 0 (184 tests, 511 assertions). The 14 warnings for @expectedException-style annotations deprecated in PHPUnit 8 are unchanged and do not fail the build. Co-authored-by: Claude Opus 5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No GitHub Actions CI here, just CircleCI. Adds a
setup-phpmatrix over 7.4 / 8.0 / 8.1 / 8.2 withfail-fast: false, matchingpackaged/daland the same versions CircleCI already built.Getting there needed one dependency change:
satooshi/php-coveralls ~1.0.0is abandoned and now makescomposer installunresolvable on every PHP version — v1.0.2 caps out at PHP 7.x, and the earlier releases pullsymfony/yaml2.x/3.x, which Composer refuses to install over published security advisories. So it's removed fromrequire-dev. Nothing used it; CircleCI never invoked coveralls, and the README badge was decorative..circleci/config.ymlis untouched — happy to remove it in a follow-up if the Actions run is the one you'll trust.Test plan
Fresh
composer installplus the full suite from a clean checkout of master, on PHP 7.4.33 and 8.2.33: both exit 0, 184 tests / 511 assertions. Both report 14 warnings for@expectedException-style annotations deprecated in PHPUnit 8 — pre-existing, and they don't fail the build. 8.0 and 8.1 get their first run on this PR.🤖 Generated with Claude Code